From 1f4abc2a6a585a14d9624da7ff1c6b46a52667dc Mon Sep 17 00:00:00 2001
From: Imbus <>
Date: Thu, 4 Apr 2024 23:02:10 +0200
Subject: [PATCH] Linter fixes and proper error handling in PromoteToPm

---
 backend/internal/handlers/projects/PromoteToPm.go        | 4 ++++
 backend/internal/handlers/reports/GetAllWeeklyReports.go | 2 +-
 backend/internal/handlers/reports/GetWeeklyReport.go     | 2 +-
 3 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/backend/internal/handlers/projects/PromoteToPm.go b/backend/internal/handlers/projects/PromoteToPm.go
index ffe2215..c587b65 100644
--- a/backend/internal/handlers/projects/PromoteToPm.go
+++ b/backend/internal/handlers/projects/PromoteToPm.go
@@ -44,6 +44,10 @@ func PromoteToPm(c *fiber.Ctx) error {
 
 	// Add the user to the project with the specified role
 	err = db.GetDb(c).ChangeUserRole(new_pm_name, project, "project_manager")
+	if err != nil {
+		log.Info("Error promoting user to project manager:", err)
+		return c.Status(500).SendString(err.Error())
+	}
 
 	// Return success message
 	log.Info("User : ", new_pm_name, " promoted to project manager in project: ", project)
diff --git a/backend/internal/handlers/reports/GetAllWeeklyReports.go b/backend/internal/handlers/reports/GetAllWeeklyReports.go
index ee81c82..506312a 100644
--- a/backend/internal/handlers/reports/GetAllWeeklyReports.go
+++ b/backend/internal/handlers/reports/GetAllWeeklyReports.go
@@ -38,7 +38,7 @@ func GetAllWeeklyReports(c *fiber.Ctx) error {
 		return c.Status(500).SendString(err.Error())
 	}
 
-	if pm == false && target_user != username {
+	if pm && target_user != username {
 		log.Info("Unauthorized access")
 		return c.Status(403).SendString("Unauthorized access")
 	}
diff --git a/backend/internal/handlers/reports/GetWeeklyReport.go b/backend/internal/handlers/reports/GetWeeklyReport.go
index 04bdc0d..206ed33 100644
--- a/backend/internal/handlers/reports/GetWeeklyReport.go
+++ b/backend/internal/handlers/reports/GetWeeklyReport.go
@@ -47,7 +47,7 @@ func GetWeeklyReport(c *fiber.Ctx) error {
 		return c.Status(500).SendString(err.Error())
 	}
 
-	if pm == false && target_user != username {
+	if pm && target_user != username {
 		log.Info("Unauthorized access")
 		return c.Status(403).SendString("Unauthorized access")
 	}