Imbus/grbl-imbus
1
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Improved fix for rare lowering feed/rapid override bug.

Browse source 
[fix] In the previous hot fix, there was still (rarer) potential for
very small floating point errors incorrectly handle an override
deceleration and crash Grbl. Re-factored the if-then statement in terms
of speed changes, rather than distance, to completely eliminate the
issue.
This commit is contained in:
Sonny Jeon 2017-08-01 10:27:42 -06:00
parent 477a94cd49
commit 5967839ab3
3 changed files with 13 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

8
doc/log/commit_log_v1.1.txt
View file

@ -1,3 +1,11 @@
----------------
Date: 2017-07-31
Author: Sonny Jeon
Subject: Hot fix for rare lowering feed override bug.
[fix] Squashed a very rare bug when lowering the feedrate (or rapid) override. When in the very strict set of circumstances with acceleration settings, override step size, and current speed, an internal calculation would cause Grbl to crash. The fix was an overlooked equality statement that should have been a less than or equal, not a less than.
----------------
Date: 2017-07-17
Author: Sonny Jeon