diff --git a/README.md b/README.md index f81709b..d244eb2 100644 --- a/README.md +++ b/README.md @@ -12,7 +12,3 @@ ### Insert & remove `sudo insmod demo_module.ko` `sudo rmmod demo_module.ko` - -### Style -Check for style with: -`${LINUX_PATH}/scripts/checkpatch.pl -f ./file.c` diff --git a/ioctl_chardev/my-ioctl.c b/ioctl_chardev/my-ioctl.c index e11696f..78b2db0 100644 --- a/ioctl_chardev/my-ioctl.c +++ b/ioctl_chardev/my-ioctl.c @@ -1,5 +1,3 @@ -// SPDX-License-Identifier: GPL-2.0 - #include #include "my-ioctl.h" @@ -16,7 +14,7 @@ static struct class *cls; static long my_ioctl(struct file *filp, unsigned int cmd, unsigned long arg); /* See: https://elixir.bootlin.com/linux/v6.14.5/source/include/linux/fs.h#L2131 */ -static const struct file_operations fops = { +static struct file_operations fops = { .owner = THIS_MODULE, .unlocked_ioctl = my_ioctl, }; diff --git a/ioctl_chardev/my-ioctl.h b/ioctl_chardev/my-ioctl.h index e558707..56b61a4 100644 --- a/ioctl_chardev/my-ioctl.h +++ b/ioctl_chardev/my-ioctl.h @@ -1,16 +1,14 @@ -/* SPDX-License-Identifier: GPL-2.0 */ - #ifndef MY_IOCTL_H #define MY_IOCTL_H #include /* * Crucial point here, the kernel defines a set of macros for defining IOCTL numbers: - * _IO - No command - * _IOR - Read command - * _IOW - Write command - * _IORW - RW command - * _IOC - Basis of the others + * _IO - No command + * _IOR - Read command + * _IOW - Write command + * _IORW - RW command + * _IOC - Basis of the others * These macros encode the data type passed to the ioctl. */ diff --git a/ioctl_chardev/test.c b/ioctl_chardev/test.c index bf45789..e379cd1 100644 --- a/ioctl_chardev/test.c +++ b/ioctl_chardev/test.c @@ -1,5 +1,3 @@ -// SPDX-License-Identifier: GPL-2.0 - #include // #include #include