Imbus/xv6-riscv-kernel
1
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

protect ip->valid and ip->nlink with sleep lock in iput()

Browse source
This commit is contained in:
Robert Morris 2017-08-08 13:48:48 -04:00
parent 3375df5061
commit 70d912b332
2 changed files with 12 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

18
fs.c
View file

@ -320,15 +320,17 @@ void
iput(struct inode *ip)
{
acquire(&icache.lock);
if(ip->ref == 1 && ip->valid && ip->nlink == 0){
// inode has no links and no other references: truncate and free.
if(ip->ref == 1){
acquiresleep(&ip->lock);
release(&icache.lock);
itrunc(ip);
ip->type = 0;
iupdate(ip);
acquire(&icache.lock);
ip->valid = 0;
if(ip->valid && ip->nlink == 0){
// inode has no links and no other references: truncate and free.
release(&icache.lock);
itrunc(ip);
ip->type = 0;
iupdate(ip);
ip->valid = 0;
acquire(&icache.lock);
}
releasesleep(&ip->lock);
}
ip->ref--;